From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sun, 14 Jan 2018 18:40:00 +0000 (+0100)
Subject: renice: add comment about getpwnam/NOFORK interaction
X-Git-Tag: 1_29_0~362
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c4144ca3a51cf5bfe7dfa5a796ae53e9ae33126c;p=oweals%2Fbusybox.git

renice: add comment about getpwnam/NOFORK interaction

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/util-linux/renice.c b/util-linux/renice.c
index 65a80001b..46704591f 100644
--- a/util-linux/renice.c
+++ b/util-linux/renice.c
@@ -6,7 +6,6 @@
  *
  * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
-
 /* Notes:
  *   Setting an absolute priority was obsoleted in SUSv2 and removed
  *   in SUSv3.  However, the common linux version of renice does
@@ -95,6 +94,7 @@ int renice_main(int argc UNUSED_PARAM, char **argv)
 		/* Process an ID arg. */
 		if (which == PRIO_USER) {
 			struct passwd *p;
+			/* NB: use of getpwnam makes it risky to be NOFORK, switch to getpwnam_r? */
 			p = getpwnam(arg);
 			if (!p) {
 				bb_error_msg("unknown user %s", arg);