From: Matt Caswell <matt@openssl.org>
Date: Wed, 18 Apr 2018 10:07:18 +0000 (+0100)
Subject: Fix ocsp app exit code
X-Git-Tag: OpenSSL_1_1_1-pre6~81
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c324ecfb2d4a6608d7a5f848968180c7995fc9a6;p=oweals%2Fopenssl.git

Fix ocsp app exit code

If we run the ocsp command line app and the responder returns a
non-successful status code then the app should exit with a failure code.

Based on an original patch by Tatsuhiro Tsujikawa.

Fixes #2387

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5998)
---

diff --git a/apps/ocsp.c b/apps/ocsp.c
index 83461c7cb5..eb822c2696 100644
--- a/apps/ocsp.c
+++ b/apps/ocsp.c
@@ -697,10 +697,8 @@ redo_accept:
     if (i != OCSP_RESPONSE_STATUS_SUCCESSFUL) {
         BIO_printf(out, "Responder Error: %s (%d)\n",
                    OCSP_response_status_str(i), i);
-        if (!ignore_err) {
-                ret = 0;
+        if (!ignore_err)
                 goto end;
-        }
     }
 
     if (resp_text)