From: est31 <MTest31@outlook.com>
Date: Mon, 4 Jul 2016 19:32:32 +0000 (+0200)
Subject: Temporarily disable "testStartStopWait" Threading unit test on mac
X-Git-Tag: 0.4.15~335
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c1bdb552bc3ec0fda1b82ab2c44a5c31ab53bd24;p=oweals%2Fminetest.git

Temporarily disable "testStartStopWait" Threading unit test on mac

The "testStartStopWait" unit test is unreliably failing on mac,
for some time already. See bug #3786.

Having the unittest fail unreliably doesn't help anybody but mostly
inhibits the main feature of travis builds: to test PRs for regressions.

Therefore, disable the specific unit test for until bug #3786
is fixed.
---

diff --git a/src/unittest/test_threading.cpp b/src/unittest/test_threading.cpp
index f0df85b2d..224e123df 100644
--- a/src/unittest/test_threading.cpp
+++ b/src/unittest/test_threading.cpp
@@ -39,7 +39,9 @@ static TestThreading g_test_instance;
 
 void TestThreading::runTests(IGameDef *gamedef)
 {
+#if !(defined(__MACH__) && defined(__APPLE__))
 	TEST(testStartStopWait);
+#endif
 	TEST(testThreadKill);
 	TEST(testAtomicSemaphoreThread);
 }