From: Benjamin Kaduk <bkaduk@akamai.com>
Date: Fri, 26 Jan 2018 01:30:54 +0000 (-0600)
Subject: Fix uninitialized read in sigalg parsing code
X-Git-Tag: OpenSSL_1_1_1-pre1~123
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c1acef9263b875cc80431b8054049dedc59cd41d;p=oweals%2Fopenssl.git

Fix uninitialized read in sigalg parsing code

The check for a duplicate value was reading one entry past
where it was supposed to, getting an uninitialized value.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5172)
---

diff --git a/ssl/t1_lib.c b/ssl/t1_lib.c
index d4c9086e5a..7109741a7d 100644
--- a/ssl/t1_lib.c
+++ b/ssl/t1_lib.c
@@ -1781,7 +1781,7 @@ static int sig_cb(const char *elem, int len, void *arg)
 
     /* Reject duplicates */
     for (i = 0; i < sarg->sigalgcnt - 1; i++) {
-        if (sarg->sigalgs[i] == sarg->sigalgs[sarg->sigalgcnt]) {
+        if (sarg->sigalgs[i] == sarg->sigalgs[sarg->sigalgcnt - 1]) {
             sarg->sigalgcnt--;
             return 0;
         }