From: Petr Štetiar <ynezz@true.cz>
Date: Tue, 19 Nov 2019 16:34:25 +0000 (+0100)
Subject: blobmsg_json: fix possible uninitialized struct member
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=c008294a8323c8cd45decde6a97aa85df2443dac;p=oweals%2Flibubox.git

blobmsg_json: fix possible uninitialized struct member

clang-10 analyzer reports following:

 blobmsg_json.c:285:2: warning: The expression is an uninitialized value. The computed value will also be garbage
         s->indent_level++;
         ^~~~~~~~~~~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/blobmsg_json.c b/blobmsg_json.c
index a5980e8..1859211 100644
--- a/blobmsg_json.c
+++ b/blobmsg_json.c
@@ -315,7 +315,7 @@ static void setup_strbuf(struct strbuf *s, struct blob_attr *attr, blobmsg_json_
 
 char *blobmsg_format_json_with_cb(struct blob_attr *attr, bool list, blobmsg_json_format_t cb, void *priv, int indent)
 {
-	struct strbuf s;
+	struct strbuf s = {0};
 	bool array;
 	char *ret;
 
@@ -349,7 +349,7 @@ char *blobmsg_format_json_with_cb(struct blob_attr *attr, bool list, blobmsg_jso
 
 char *blobmsg_format_json_value_with_cb(struct blob_attr *attr, blobmsg_json_format_t cb, void *priv, int indent)
 {
-	struct strbuf s;
+	struct strbuf s = {0};
 	char *ret;
 
 	setup_strbuf(&s, attr, cb, priv, indent);