From: Bin Meng Date: Mon, 9 Sep 2019 13:00:03 +0000 (-0700) Subject: test: dm: spi: Fix sandbox dm_test_spi_find() X-Git-Tag: v2020.04-rc1~1^2~9 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=bfcd9298b29c16fdada9d8e772dd9aaff7760f43;p=oweals%2Fu-boot.git test: dm: spi: Fix sandbox dm_test_spi_find() Per sandbox_cs_info(), sandbox spi controller only supports chip select 0. Current test case tries to locate devices on chip select 1, and any call to spi_get_bus_and_cs() or spi_cs_info() with cs number 1 should not return 0. This updates the test case to handle it correctly. Signed-off-by: Bin Meng Reviewed-by: Jagan Teki --- diff --git a/test/dm/spi.c b/test/dm/spi.c index ffd789cd7f..8e417acc5f 100644 --- a/test/dm/spi.c +++ b/test/dm/spi.c @@ -77,10 +77,10 @@ static int dm_test_spi_find(struct unit_test_state *uts) /* We should be able to add something to another chip select */ ut_assertok(sandbox_sf_bind_emul(state, busnum, cs_b, bus, node, "name")); - ut_assertok(spi_get_bus_and_cs(busnum, cs_b, speed, mode, + ut_asserteq(-EINVAL, spi_get_bus_and_cs(busnum, cs_b, speed, mode, "spi_flash_std", "name", &bus, &slave)); - ut_assertok(spi_cs_info(bus, cs_b, &info)); - ut_asserteq_ptr(info.dev, slave->dev); + ut_asserteq(-EINVAL, spi_cs_info(bus, cs_b, &info)); + ut_asserteq_ptr(NULL, info.dev); /* * Since we are about to destroy all devices, we must tell sandbox