From: Michal Simek <michal.simek@xilinx.com>
Date: Mon, 30 Jul 2018 08:02:53 +0000 (+0200)
Subject: gpio: xilinx: Set value before changing direction
X-Git-Tag: v2018.09-rc2~65^2~6
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=bf2a69de81908f36a5853b36cc2afbd976856e3b;p=oweals%2Fu-boot.git

gpio: xilinx: Set value before changing direction

Set a value before changing gpio direction. This will ensure that the
old value is not propagated when direction has changed but new value is
not written yet.

Reported-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
---

diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
index 776a147cc8..1e5f3da8d7 100644
--- a/drivers/gpio/xilinx_gpio.c
+++ b/drivers/gpio/xilinx_gpio.c
@@ -139,14 +139,14 @@ static int xilinx_gpio_direction_output(struct udevice *dev, unsigned offset,
 	if (platdata->bank_input[bank])
 		return -EINVAL;
 
+	xilinx_gpio_set_value(dev, offset, value);
+
 	if (!platdata->bank_output[bank]) {
 		val = readl(&platdata->regs->gpiodir + bank * 2);
 		val = val & ~(1 << pin);
 		writel(val, &platdata->regs->gpiodir + bank * 2);
 	}
 
-	xilinx_gpio_set_value(dev, offset, value);
-
 	return 0;
 }