From: Bastian Bittorf <bb@npl.de>
Date: Fri, 13 Jan 2017 19:22:51 +0000 (+0100)
Subject: procd: update procd.sh to disallow signal-numbers, enforce signal-names
X-Git-Tag: v17.01.0-rc2~58
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=be7480cb5a5a4879f41acb6e4f11c8759d178b75;p=oweals%2Fopenwrt.git

procd: update procd.sh to disallow signal-numbers, enforce signal-names

A given signal-name is now converted to the corresonding number. In general
it's good style to use names (readability) and it's more portable: signal
numbers can be architecture-dependent, so we are more safe giving names.

A real world example is signal 10, which is BUS on ramips and USR1 on PPC.

All users of 'procd_send_signal' must change their code to reflect this.

Signed-off-by: Bastian Bittorf <bb@npl.de>
---

diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh
index 8f18cda70e..a1b9f2f0e9 100644
--- a/package/system/procd/files/procd.sh
+++ b/package/system/procd/files/procd.sh
@@ -213,9 +213,12 @@ _procd_set_param() {
 			json_add_string "" "$@"
 			json_close_array
 		;;
-		nice|reload_signal)
+		nice)
 			json_add_int "$type" "$1"
 		;;
+		reload_signal)
+			json_add_int "$type" $(kill -l "$1")
+		;;
 		pidfile|user|seccomp|capabilities)
 			json_add_string "$type" "$1"
 		;;