From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sat, 9 May 2020 15:59:19 +0000 (+0200)
Subject: cmd: efidebug: fix -Werror=type-limits warning
X-Git-Tag: v2020.07-rc2~1^2
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=bdb15776f6d93a1fe7902346db06a2a9fd43381e;p=oweals%2Fu-boot.git

cmd: efidebug: fix -Werror=type-limits warning

Compiling with -Wtype-limits yields:

cmd/efidebug.c:968:32: error: comparison is always false due to limited
range of data type [-Werror=type-limits]
  968 |  if (*endp != '\0' || bootnext > 0xffff) {
      |

Remove the superfluous check.

Fixes: 59df7e7e77e7 ("cmd: add efidebug command")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 668e5c4e87..5cc0a41af3 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -970,7 +970,7 @@ static int do_efi_boot_next(cmd_tbl_t *cmdtp, int flag,
 		return CMD_RET_USAGE;
 
 	bootnext = (u16)simple_strtoul(argv[1], &endp, 16);
-	if (*endp != '\0' || bootnext > 0xffff) {
+	if (*endp) {
 		printf("invalid value: %s\n", argv[1]);
 		r = CMD_RET_FAILURE;
 		goto out;