From: Nathan Rossi <nathan@nathanrossi.com>
Date: Tue, 8 Dec 2015 14:44:43 +0000 (+1000)
Subject: tools: zynqimage: Clean up check_params
X-Git-Tag: v2016.01-rc3~17^2~14
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=bc3660503588b0cb780e5fc1797393127425149c;p=oweals%2Fu-boot.git

tools: zynqimage: Clean up check_params

Clean up the param checking, removing some code paths that will never
happen.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Tom Rini <trini@konsulko.com>
Reported-by: Coverity (CID 133251)
Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

diff --git a/tools/zynqimage.c b/tools/zynqimage.c
index 25f558d24c..c43bd5d488 100644
--- a/tools/zynqimage.c
+++ b/tools/zynqimage.c
@@ -212,8 +212,7 @@ static int zynqimage_check_params(struct image_tool_params *params)
 		return -1;
 	}
 
-	return !((params->lflag || params->dflag) ||
-			(params->dflag && params->eflag));
+	return !(params->lflag || params->dflag);
 }
 
 static int zynqimage_check_image_types(uint8_t type)