From: Jo-Philipp Wich Date: Wed, 1 Aug 2018 20:33:49 +0000 (+0200) Subject: Revert "ar71xx: ag71xx: Prevent kernel oops for board def" X-Git-Tag: v19.07.0-rc1~2934 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b9bd3285c7c6fbc60374b05ac2da9be41ce75651;p=oweals%2Fopenwrt.git Revert "ar71xx: ag71xx: Prevent kernel oops for board def" This reverts commit 7a3e133751870a3431e2430386a77a002eb24117. This change reportedly breaks connectivity on some ar71xx devices, so revert it for now. Ref: https://github.com/openwrt/openwrt/pull/1217#issuecomment-409708087 Reported-by: Hannu Nyman Signed-off-by: Jo-Philipp Wich --- diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c index daa373be69..12fa2e301b 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c @@ -76,24 +76,10 @@ void ag71xx_phy_stop(struct ag71xx *ag) static int ag71xx_phy_connect_fixed(struct ag71xx *ag) { - struct platform_device *pdev = ag->pdev; - struct device *dev = NULL; + struct device *dev = &ag->pdev->dev; struct ag71xx_platform_data *pdata = ag71xx_get_pdata(ag); int ret = 0; - if (!pdev) - return -ENODEV; - - dev = &pdev->dev; - - if (!dev) - return -ENODEV; - - if (!ag->phy_dev) { - pr_err("Missing PHY for %s", dev_name(dev)); - return -ENODEV; - } - /* use fixed settings */ switch (pdata->speed) { case SPEED_10: