From: Rosen Penev Date: Fri, 17 Jan 2020 04:43:56 +0000 (-0800) Subject: base-files/functions.sh: remove useless cat X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b8e17aefea91632a70634aa2828a8b548c2b2567;p=oweals%2Fopenwrt.git base-files/functions.sh: remove useless cat The cut command can take a file as an input. https://github.com/koalaman/shellcheck/wiki/SC2002 Signed-off-by: Rosen Penev --- diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh index b118c8368c..40a7527aa5 100755 --- a/package/base-files/files/lib/functions.sh +++ b/package/base-files/files/lib/functions.sh @@ -324,7 +324,7 @@ group_add_next() { echo $gid return fi - gids=$(cat ${IPKG_INSTROOT}/etc/group | cut -d: -f3) + gids=$(cut -d: -f3 ${IPKG_INSTROOT}/etc/group) gid=65536 while [ -n "$(echo "$gids" | grep "^$gid$")" ] ; do gid=$((gid + 1)) @@ -352,7 +352,7 @@ user_add() { local shell="${6:-/bin/false}" local rc [ -z "$uid" ] && { - uids=$(cat ${IPKG_INSTROOT}/etc/passwd | cut -d: -f3) + uids=$(cut -d: -f3 ${IPKG_INSTROOT}/etc/passwd) uid=65536 while [ -n "$(echo "$uids" | grep "^$uid$")" ] ; do uid=$((uid + 1))