From: Jo-Philipp Wich <jo@mein.io>
Date: Mon, 13 Apr 2020 10:31:54 +0000 (+0200)
Subject: luci-base: ui.js: use standard indicator framework to display uci changes
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b6e93d54a0f9c6be310e07a66ac08532ba6400b0;p=oweals%2Fluci.git

luci-base: ui.js: use standard indicator framework to display uci changes

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js
index 17e70e4f9..2e4e4ad1c 100644
--- a/modules/luci-base/htdocs/luci-static/resources/ui.js
+++ b/modules/luci-base/htdocs/luci-static/resources/ui.js
@@ -3800,26 +3800,13 @@ var UI = baseclass.extend(/** @lends LuCI.ui.prototype */ {
 		 * The number of changes to indicate.
 		 */
 		setIndicator: function(n) {
-			var i = document.querySelector('.uci_change_indicator');
-			if (i == null) {
-				var poll = document.getElementById('xhr_poll_status');
-				i = poll.parentNode.insertBefore(E('a', {
-					'href': '#',
-					'class': 'uci_change_indicator label notice',
-					'click': L.bind(this.displayChanges, this)
-				}), poll);
-			}
-
 			if (n > 0) {
-				dom.content(i, [ _('Unsaved Changes'), ': ', n ]);
-				i.classList.add('flash');
-				i.style.display = '';
-				document.dispatchEvent(new CustomEvent('uci-new-changes'));
+				UI.prototype.showIndicator('uci-changes',
+					'%s: %d'.format(_('Unsaved Changes'), n),
+					L.bind(this.displayChanges, this));
 			}
 			else {
-				i.classList.remove('flash');
-				i.style.display = 'none';
-				document.dispatchEvent(new CustomEvent('uci-clear-changes'));
+				UI.prototype.hideIndicator('uci-changes');
 			}
 		},