From: Eric Andersen Date: Fri, 14 Nov 2003 03:04:08 +0000 (-0000) Subject: Michael Smith writes: X-Git-Tag: 1_00_pre4~66 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b6e58d2b9a02dfcf313e064408aea1359a4d9763;p=oweals%2Fbusybox.git Michael Smith writes: I noticed a problem with ifconfig in busybox 0.60.5. The matching code seems to exist in busybox CVS as well, so I'll paste in the patch that fixed it. I was running: # ifconfig wan0 1.2.3.4 pointopoint 1.2.3.5 netmask 255.255.255.255 I was seeing the inet addr and P-t-P addr both being set to 1.2.3.5 (the pointopoint address). wan0 Link encap:Point-Point Protocol inet addr:1.2.3.5 P-t-P:1.2.3.5 Mask:255.255.255.255 UP POINTOPOINT RUNNING NOARP MTU:1500 Metric:1 ... The patch below seems to fix it. --- diff --git a/networking/ifconfig.c b/networking/ifconfig.c index ef6a6f746..9fdab3c3f 100644 --- a/networking/ifconfig.c +++ b/networking/ifconfig.c @@ -15,7 +15,7 @@ * Foundation; either version 2 of the License, or (at * your option) any later version. * - * $Id: ifconfig.c,v 1.26 2003/06/21 09:05:49 andersen Exp $ + * $Id: ifconfig.c,v 1.27 2003/11/14 03:04:08 andersen Exp $ * */ @@ -163,7 +163,7 @@ struct in6_ifreq { #define ARG_NETMASK (A_ARG_REQ | A_CAST_HOST_COPY_RESOLVE | A_NETMASK) #define ARG_BROADCAST (A_ARG_REQ | A_CAST_HOST_COPY_RESOLVE | A_SET_AFTER | A_BROADCAST) #define ARG_HW (A_ARG_REQ | A_CAST_HOST_COPY_IN_ETHER) -#define ARG_POINTOPOINT (A_CAST_HOST_COPY_RESOLVE | A_SET_AFTER) +#define ARG_POINTOPOINT (A_ARG_REQ | A_CAST_HOST_COPY_RESOLVE | A_SET_AFTER) #define ARG_KEEPALIVE (A_ARG_REQ | A_CAST_CHAR_PTR) #define ARG_OUTFILL (A_ARG_REQ | A_CAST_CHAR_PTR) #define ARG_HOSTNAME (A_CAST_HOST_COPY_RESOLVE | A_SET_AFTER | A_COLON_CHK | A_HOSTNAME)