From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sat, 12 Jan 2019 10:51:58 +0000 (+0100)
Subject: adduser: fix a bug of getpwnam() overwriting shell name, closes 8586
X-Git-Tag: 1_31_0~211
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b67d900395a847e29f2afa81198f783004c80fc5;p=oweals%2Fbusybox.git

adduser: fix a bug of getpwnam() overwriting shell name, closes 8586

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/loginutils/adduser.c b/loginutils/adduser.c
index b2b5be5b3..850c810c4 100644
--- a/loginutils/adduser.c
+++ b/loginutils/adduser.c
@@ -198,7 +198,7 @@ int adduser_main(int argc UNUSED_PARAM, char **argv)
 
 	pw.pw_gecos = (char *)"Linux User,,,";
 	/* We assume that newly created users "inherit" root's shell setting */
-	pw.pw_shell = (char *)get_shell_name();
+	pw.pw_shell = xstrdup(get_shell_name()); /* might come from getpwnam(), need to make a copy */
 	pw.pw_dir = NULL;
 
 	opts = getopt32long(argv, "^"