From: Philippe Reynes <philippe.reynes@softathome.com>
Date: Tue, 19 Mar 2019 09:55:40 +0000 (+0100)
Subject: rsa: check that pointer checksum isn't NULL before using it
X-Git-Tag: v2019.04~21^2~2
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=b02f2e79c6272d97bf0bd191e6ec8e748a39ad58;p=oweals%2Fu-boot.git

rsa: check that pointer checksum isn't NULL before using it

The pointer checksum were used before checking that it
isn't NULL. We move the code that use it after the check.

Reported-by: Coverity (CID: 185835)
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 9734f6d3bd..287fcc4d23 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -295,7 +295,7 @@ static int rsa_verify_key(struct image_sign_info *info,
 #endif
 	struct checksum_algo *checksum = info->checksum;
 	struct padding_algo *padding = info->padding;
-	int hash_len = checksum->checksum_len;
+	int hash_len;
 
 	if (!prop || !sig || !hash || !checksum)
 		return -EIO;
@@ -315,6 +315,7 @@ static int rsa_verify_key(struct image_sign_info *info,
 	}
 
 	uint8_t buf[sig_len];
+	hash_len = checksum->checksum_len;
 
 #if !defined(USE_HOSTCC)
 	ret = uclass_get_device(UCLASS_MOD_EXP, 0, &mod_exp_dev);