From: Matthias Schiffer <mschiffer@universe-factory.net>
Date: Sat, 16 May 2020 11:33:55 +0000 (+0200)
Subject: Fix return code of write_file()
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=afc86f352bf7915f81e9d38949e91306542aadee;p=oweals%2Fucert.git

Fix return code of write_file()

write_file() returns 1/true on success; it should return 0/false when
opening the file fails.

To make it more obvious that is function returns true and not 0 on
success, also change its return type to bool.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
---

diff --git a/ucert.c b/ucert.c
index 2ea9399..7de4c12 100644
--- a/ucert.c
+++ b/ucert.c
@@ -116,13 +116,13 @@ struct cert_object {
 };
 
 /* write buffer to file */
-static int write_file(const char *filename, void *buf, size_t len, bool append) {
+static bool write_file(const char *filename, void *buf, size_t len, bool append) {
 	FILE *f;
 	size_t outlen;
 
 	f = fopen(filename, append?"a":"w");
 	if (!f)
-		return 1;
+		return false;
 
 	outlen = fwrite(buf, 1, len, f);
 	fclose(f);