From: Todd Short <tshort@akamai.com>
Date: Wed, 9 Mar 2016 15:01:43 +0000 (-0500)
Subject: Fix locking in ssl_cert_dup()
X-Git-Tag: OpenSSL_1_1_0-pre4~147
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=aeb5b95576025d651c4941e7a5c157351094de84;p=oweals%2Fopenssl.git

Fix locking in ssl_cert_dup()

Properly check the return value of CRYPTO_THREAD_lock_new()

Signed-off-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
---

diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c
index 21cfb965d2..8915531d42 100644
--- a/ssl/ssl_cert.c
+++ b/ssl/ssl_cert.c
@@ -190,7 +190,7 @@ CERT *ssl_cert_dup(CERT *cert)
     ret->references = 1;
     ret->key = &ret->pkeys[cert->key - cert->pkeys];
     ret->lock = CRYPTO_THREAD_lock_new();
-    if (ret == NULL) {
+    if (ret->lock == NULL) {
         SSLerr(SSL_F_SSL_CERT_DUP, ERR_R_MALLOC_FAILURE);
         OPENSSL_free(ret);
         return NULL;