From: Philipp Tomsich Date: Mon, 19 Nov 2018 12:03:51 +0000 (+0100) Subject: rockchip: rk3399: spl: always report errors triggering a hard stop X-Git-Tag: v2019.01-rc1~15^2~12 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=adbca53a3a0e2c7843561330d80d97660f347d76;p=oweals%2Fu-boot.git rockchip: rk3399: spl: always report errors triggering a hard stop The RK3399 SPL has two cases that may end in a hard-stop: if either the pinctrl can not be initialised or if the DRAM fails to initialise. Both have previously not triggered an error message unless DEBUG was defined (i.e. both used debug() to print the error). This converts both error messages to be printed using pr_err() to ensure that some output points to the cause of the hard-stop. Signed-off-by: Philipp Tomsich --- diff --git a/arch/arm/mach-rockchip/rk3399-board-spl.c b/arch/arm/mach-rockchip/rk3399-board-spl.c index 43350e38b1..0198c6c65f 100644 --- a/arch/arm/mach-rockchip/rk3399-board-spl.c +++ b/arch/arm/mach-rockchip/rk3399-board-spl.c @@ -202,13 +202,13 @@ void board_init_f(ulong dummy) ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl); if (ret) { - debug("Pinctrl init failed: %d\n", ret); + pr_err("Pinctrl init failed: %d\n", ret); return; } ret = uclass_get_device(UCLASS_RAM, 0, &dev); if (ret) { - debug("DRAM init failed: %d\n", ret); + pr_err("DRAM init failed: %d\n", ret); return; } }