From: Tom Rini Date: Tue, 12 Apr 2016 19:11:23 +0000 (-0400) Subject: drivers/gpio/pm8916_gpio.c: Make pid be uint32_t X-Git-Tag: v2016.05-rc2~23 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=aa997d1d774416b3525d44779ee7ff9914b6abcb;p=oweals%2Fu-boot.git drivers/gpio/pm8916_gpio.c: Make pid be uint32_t If get_dev_addr fails it will return FDT_ADDR_T_NONE and: >>> "priv->pid == 4294967295U" is always false regardless of the values of its operands. This occurs as the logical operand of if. Cc: Mateusz Kulikowski Reported-by: Coverity (CID: 143913) Signed-off-by: Tom Rini --- diff --git a/drivers/gpio/pm8916_gpio.c b/drivers/gpio/pm8916_gpio.c index 1abab7fef1..0b61975843 100644 --- a/drivers/gpio/pm8916_gpio.c +++ b/drivers/gpio/pm8916_gpio.c @@ -50,7 +50,7 @@ DECLARE_GLOBAL_DATA_PTR; #define REG_EN_CTL_ENABLE (1 << 7) struct pm8916_gpio_bank { - uint16_t pid; /* Peripheral ID on SPMI bus */ + uint32_t pid; /* Peripheral ID on SPMI bus */ }; static int pm8916_gpio_set_direction(struct udevice *dev, unsigned offset,