From: Jon Trulson <jon@radscan.com>
Date: Sat, 27 Dec 2014 01:10:07 +0000 (-0700)
Subject: dtwm/WmFP: Coverity (memory corruption, moderate)
X-Git-Tag: 2.2.3~65
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a71cde075e950d51474112368dc837a421c3171e;p=oweals%2Fcde.git

dtwm/WmFP: Coverity (memory corruption, moderate)
---

diff --git a/cde/programs/dtwm/WmFP.c b/cde/programs/dtwm/WmFP.c
index 22dcb638..bd7fe7c5 100644
--- a/cde/programs/dtwm/WmFP.c
+++ b/cde/programs/dtwm/WmFP.c
@@ -745,8 +745,6 @@ WmPanelistShow (Widget w)
    int i;
    Arg al[20];
    int ac;
-   
-
 
    /*  Find the switch data for later processing  */
    
@@ -785,16 +783,15 @@ WmPanelistShow (Widget w)
    if (shell_geometry == NULL)
    {
       Position  x;
-      char      geometry_buffer[32];
 
       if (panel.element_values[PANEL_GEOMETRY].string_value != NULL)
       {
-         shell_geometry = panel.element_values[PANEL_GEOMETRY].parsed_value;
+        shell_geometry = panel.element_values[PANEL_GEOMETRY].parsed_value;
       }
       else
       {
          x = (screen_width > width) ? (Position)(screen_width - width) / 2 : 0;
-         sprintf (geometry_buffer, "+%d-0", x);
+         snprintf (geometry_buffer, 32 - 1, "+%d-0", x);
          shell_geometry = geometry_buffer;
       }