From: Denys Vlasenko Date: Tue, 10 Sep 2013 14:27:08 +0000 (+0200) Subject: ar: better comment X-Git-Tag: 1_22_0~90 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a613aa1b4c26be1567a59e9216c83d21d4be122b;p=oweals%2Fbusybox.git ar: better comment Signed-off-by: Denys Vlasenko --- diff --git a/archival/libarchive/get_header_ar.c b/archival/libarchive/get_header_ar.c index f655585fe..c66bb3ee7 100644 --- a/archival/libarchive/get_header_ar.c +++ b/archival/libarchive/get_header_ar.c @@ -59,6 +59,11 @@ char FAST_FUNC get_header_ar(archive_handle_t *archive_handle) if (ar.formatted.magic[0] != '`' || ar.formatted.magic[1] != '\n') bb_error_msg_and_die("invalid ar header"); + /* + * Note that the fields MUST be read in reverse order as + * read_num() clobbers the next byte after the field! + * Order is: name, date, uid, gid, mode, size, magic. + */ typed->size = size = read_num(ar.formatted.size, 10, sizeof(ar.formatted.size)); @@ -91,8 +96,6 @@ char FAST_FUNC get_header_ar(archive_handle_t *archive_handle) /* Only size is always present, the rest may be missing in * long filename pseudo file. Thus we decode the rest * after dealing with long filename pseudo file. - * Note that the fields MUST be read in reverse order as - * read_num() clobbers the next byte after the field! */ typed->mode = read_num(ar.formatted.mode, 8, sizeof(ar.formatted.mode)); typed->gid = read_num(ar.formatted.gid, 10, sizeof(ar.formatted.gid));