From: Dr. Stephen Henson <steve@openssl.org>
Date: Tue, 19 Jun 2001 17:13:48 +0000 (+0000)
Subject: Fix memory leaks.
X-Git-Tag: OpenSSL_0_9_6c~182^2~98
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a45e4a5537e009761652db0d9aa1ef28b1ce8937;p=oweals%2Fopenssl.git

Fix memory leaks.
---

diff --git a/apps/engine.c b/apps/engine.c
index 31221ed867..faeeb7e200 100644
--- a/apps/engine.c
+++ b/apps/engine.c
@@ -183,14 +183,12 @@ static int util_verbose(ENGINE *e, int verbose, BIO *bio_out, const char *indent
 	{
 	static const int line_wrap = 78;
 	int num;
+	int ret = 0;
 	char *name = NULL;
 	char *desc = NULL;
 	int flags;
 	int xpos = 0;
-	STACK *cmds = sk_new_null();
-
-	if(!cmds)
-		goto err;
+	STACK *cmds = NULL;
 	if(!ENGINE_ctrl(e, ENGINE_CTRL_HAS_CTRL_FUNCTION, 0, NULL, NULL) ||
 			((num = ENGINE_ctrl(e, ENGINE_CTRL_GET_FIRST_CMD_TYPE,
 					0, NULL, NULL)) <= 0))
@@ -200,6 +198,11 @@ static int util_verbose(ENGINE *e, int verbose, BIO *bio_out, const char *indent
 #endif
 		return 1;
 		}
+
+	cmds = sk_new_null();
+
+	if(!cmds)
+		goto err;
 	do {
 		int len;
 		/* Get the command name */
@@ -264,12 +267,12 @@ static int util_verbose(ENGINE *e, int verbose, BIO *bio_out, const char *indent
 		} while(num > 0);
 	if(xpos > 0)
 		BIO_printf(bio_out, "\n");
-	return 1;
+	ret = 1;
 err:
 	if(cmds) sk_pop_free(cmds, identity);
 	if(name) OPENSSL_free(name);
 	if(desc) OPENSSL_free(desc);
-	return 0;
+	return ret;
 	}
 
 static void util_do_cmds(ENGINE *e, STACK *cmds, BIO *bio_out, const char *indent)