From: Rich Felker <dalias@aerifal.cx>
Date: Thu, 18 Oct 2018 17:33:11 +0000 (-0400)
Subject: fix wrong result for putc variants due to operator precedence
X-Git-Tag: v1.1.21~39
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a21a6092cfc0c7e7cb8c0273e5f94d54c0e0eabd;p=oweals%2Fmusl.git

fix wrong result for putc variants due to operator precedence

the internal putc_unlocked macro was wrongly returning a meaningless
boolean result rather than the written character or EOF.

bug was found by reading (very surprising) asm.
---

diff --git a/src/internal/stdio_impl.h b/src/internal/stdio_impl.h
index ab34da2a..44497344 100644
--- a/src/internal/stdio_impl.h
+++ b/src/internal/stdio_impl.h
@@ -105,7 +105,7 @@ hidden void __getopt_msg(const char *, const char *, const char *, size_t);
 	( ((f)->rpos != (f)->rend) ? *(f)->rpos++ : __uflow((f)) )
 
 #define putc_unlocked(c, f) \
-	( ((unsigned char)(c)!=(f)->lbf && (f)->wpos!=(f)->wend) \
+	( (((unsigned char)(c)!=(f)->lbf && (f)->wpos!=(f)->wend)) \
 	? *(f)->wpos++ = (c) : __overflow((f),(c)) )
 
 /* Caller-allocated FILE * operations */