From: Eric Andersen Date: Wed, 23 May 2001 23:46:09 +0000 (-0000) Subject: Plug another memory leak in hush. This one showed up when backticked X-Git-Tag: 0_52~135 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a15dc15f12766709ecd27be001a5832a11e6b353;p=oweals%2Fbusybox.git Plug another memory leak in hush. This one showed up when backticked commands were run. This one was sure a bugger to find. -Erik --- diff --git a/hush.c b/hush.c index 57b85d1bc..bb1397179 100644 --- a/hush.c +++ b/hush.c @@ -2166,6 +2166,7 @@ static int process_command_subs(o_string *dest, struct p_context *ctx, struct in * to the KISS philosophy of this program. */ mark_closed(fileno(p)); retcode=pclose(p); + free_pipe_list(inner.list_head,0); debug_printf("pclosed, retcode=%d\n",retcode); /* XXX this process fails to trim a single trailing newline */ return retcode; diff --git a/shell/hush.c b/shell/hush.c index 57b85d1bc..bb1397179 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -2166,6 +2166,7 @@ static int process_command_subs(o_string *dest, struct p_context *ctx, struct in * to the KISS philosophy of this program. */ mark_closed(fileno(p)); retcode=pclose(p); + free_pipe_list(inner.list_head,0); debug_printf("pclosed, retcode=%d\n",retcode); /* XXX this process fails to trim a single trailing newline */ return retcode;