From: Davide Galassi <davide.galassi@gmail.com>
Date: Mon, 18 Apr 2016 13:48:27 +0000 (+0200)
Subject: BIO socket connect failure was not handled correctly.
X-Git-Tag: OpenSSL_1_1_0-pre6~1095
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=a043d0b91d62fd8526a3fd791e3ad2ebcf888cd9;p=oweals%2Fopenssl.git

BIO socket connect failure was not handled correctly.
The state was always set to BIO_CONN_S_OK.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/bio/bss_conn.c b/crypto/bio/bss_conn.c
index a4949b3d60..c1abe87e25 100644
--- a/crypto/bio/bss_conn.c
+++ b/crypto/bio/bss_conn.c
@@ -198,7 +198,7 @@ static int conn_state(BIO *b, BIO_CONNECT *c)
             ret = BIO_connect(b->num, BIO_ADDRINFO_address(c->addr_iter),
                               BIO_SOCK_KEEPALIVE | c->connect_mode);
             b->retry_reason = 0;
-            if (ret < 0) {
+            if (ret == 0) {
                 if (BIO_sock_should_retry(ret)) {
                     BIO_set_retry_special(b);
                     c->state = BIO_CONN_S_BLOCKED_CONNECT;