From: Rafał Miłecki Date: Thu, 9 Nov 2017 14:08:16 +0000 (+0100) Subject: plugin: use RTLD_LOCAL instead of RTLD_GLOBAL when loading library X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=9a8640183c031ece7742fd58d8c7927863c96cf7;p=oweals%2Frpcd.git plugin: use RTLD_LOCAL instead of RTLD_GLOBAL when loading library RTLD_GLOBAL was used to allow plugins use each other symbols but this facility was (most likely) never used and is a bad design anyway. If there is a common code it should just go to a library. Using RTLD_LOCAL on the other hand saves us from conflicting symbols used by different plugins. An example can be iwinfo plugin using libnl. If there appears to be another plugin using incompatible netlink implementation this will result in a problem. Both plugins will start using the same libnl which will break one of them. Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich --- diff --git a/plugin.c b/plugin.c index 70d2c56..532fa15 100644 --- a/plugin.c +++ b/plugin.c @@ -412,7 +412,7 @@ rpc_plugin_register_library(struct ubus_context *ctx, const char *path) struct rpc_plugin *p; void *dlh; - dlh = dlopen(path, RTLD_LAZY | RTLD_GLOBAL); + dlh = dlopen(path, RTLD_LAZY | RTLD_LOCAL); if (!dlh) return UBUS_STATUS_UNKNOWN_ERROR;