From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Fri, 10 May 2019 18:06:48 +0000 (+0200)
Subject: efi_loader: error code in UninstallProtocolInterface()
X-Git-Tag: v2019.07-rc2~3^2~8
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=96aa99cded0096bd6c6ea2919e6884c54c80f095;p=oweals%2Fu-boot.git

efi_loader: error code in UninstallProtocolInterface()

According to the UEFI specification UninstallProtocolInteface() has to
return EFI_NOT_FOUND if the interface is not found.

Correct the return value.

Cf. UEFI SCT II spec (2017), 3.3.2 UninstallProtocolInterface(), 5.1.3.2.4

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index b8589b9531..b583ac6a42 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -514,7 +514,7 @@ efi_status_t efi_remove_protocol(const efi_handle_t handle,
 	if (ret != EFI_SUCCESS)
 		return ret;
 	if (handler->protocol_interface != protocol_interface)
-		return EFI_INVALID_PARAMETER;
+		return EFI_NOT_FOUND;
 	list_del(&handler->link);
 	free(handler);
 	return EFI_SUCCESS;