From: Benjamin Kaduk <bkaduk@akamai.com>
Date: Mon, 18 Apr 2016 17:50:34 +0000 (-0500)
Subject: Remove dead-code infinite loop
X-Git-Tag: OpenSSL_1_1_0-pre6~1053
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=9547982e8c63eb3e0ca8d3ebb90ed612eb7ac932;p=oweals%2Fopenssl.git

Remove dead-code infinite loop

Commit d32f5d8733df9938727710d4194e92813c421ef1 added a 'goto end;' statement
at the end of the code block for the 'end' label.  Fortunately, it was after a
return statement, so no infinite loop occurred, but it is still dead code.

Remove the extra goto statement as cleanup.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/ocsp/ocsp_vfy.c b/crypto/ocsp/ocsp_vfy.c
index 2b55401aea..133e09ba28 100644
--- a/crypto/ocsp/ocsp_vfy.c
+++ b/crypto/ocsp/ocsp_vfy.c
@@ -176,7 +176,6 @@ int OCSP_basic_verify(OCSP_BASICRESP *bs, STACK_OF(X509) *certs,
     if (bs->certs && certs)
         sk_X509_free(untrusted);
     return ret;
-    goto end;
 
  err:
     ret = 0;