From: Paul Yang <kaishen.yy@antfin.com>
Date: Mon, 30 Sep 2019 03:33:24 +0000 (+0800)
Subject: Fix a return value bug in apps/speed.c
X-Git-Tag: openssl-3.0.0-alpha1~1250
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=94bd168a9e31d1ab4986e94056dfae71ec5f051f;p=oweals%2Fopenssl.git

Fix a return value bug in apps/speed.c

Those functions returns less than and equal to 0 to indicate an error
occured.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/10054)
---

diff --git a/apps/speed.c b/apps/speed.c
index 59594f0e49..33f77d3b2c 100644
--- a/apps/speed.c
+++ b/apps/speed.c
@@ -3249,8 +3249,8 @@ int speed_main(int argc, char **argv)
 
             if ((ed_pctx = EVP_PKEY_CTX_new_id(test_ed_curves[testnum].nid, NULL))
                     == NULL
-                || !EVP_PKEY_keygen_init(ed_pctx)
-                || !EVP_PKEY_keygen(ed_pctx, &ed_pkey)) {
+                || EVP_PKEY_keygen_init(ed_pctx) <= 0
+                || EVP_PKEY_keygen(ed_pctx, &ed_pkey) <= 0) {
                 st = 0;
                 EVP_PKEY_CTX_free(ed_pctx);
                 break;