From: Adam Ford Date: Tue, 15 Jan 2019 17:26:48 +0000 (-0600) Subject: net: dm: fec: Fix regulator enable when using DM_REGULATOR X-Git-Tag: v2019.04-rc2~9^2~45 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8f1a5ac797baac5b40f93eac80a7810f0a771ecf;p=oweals%2Fu-boot.git net: dm: fec: Fix regulator enable when using DM_REGULATOR When DM_REGULATOR is enabled, the driver attempts to call regulator_autoset() which expects the regulators to be on at boot and/or always on and fails if they are not true. For a more generic approach, this patch just calls regulator_set_enable() which shouldn't have such restrictions. Fixes: ad8c43cbcafb ("net: dm: fec: Support the phy-supply binding") Signed-off-by: Adam Ford Tested-by: Martin Fuzzey Acked-by: Joe Hershberger --- diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 1a59026a62..a14fe43a5b 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1348,7 +1348,7 @@ static int fecmxc_probe(struct udevice *dev) #ifdef CONFIG_DM_REGULATOR if (priv->phy_supply) { - ret = regulator_autoset(priv->phy_supply); + ret = regulator_set_enable(priv->phy_supply, true); if (ret) { printf("%s: Error enabling phy supply\n", dev->name); return ret;