From: Peter Howkins Date: Fri, 13 Jul 2018 16:57:53 +0000 (+0100) Subject: dtcm: Coverity 88575 X-Git-Tag: 2.3.0a~109 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8eab8d07cea441a1299a9254eac0136fec81c6f3;p=oweals%2Fcde.git dtcm: Coverity 88575 --- diff --git a/cde/programs/dtcm/server/rtable2.c b/cde/programs/dtcm/server/rtable2.c index 5a25b3ad..86f8af04 100644 --- a/cde/programs/dtcm/server/rtable2.c +++ b/cde/programs/dtcm/server/rtable2.c @@ -231,12 +231,14 @@ _DtCm_rtable_change_2_svc(Table_Args_2 *args, struct svc_req *svcrq) if (res!=NULL) xdr_free ((xdrproc_t)_DtCm_xdr_Table_Res_2, (char*)res); - newargs = _DtCm_tableargs2_to_tableargs4(args); - newres = _DtCm_rtable_change_4_svc(newargs, svcrq); - res = _DtCm_tableres4_to_tableres2(newres); + newargs = _DtCm_tableargs2_to_tableargs4(args); + if(newargs) { + newres = _DtCm_rtable_change_4_svc(newargs, svcrq); + res = _DtCm_tableres4_to_tableres2(newres); - if (newargs!=NULL) xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs); - + xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs); + } + return(res); }