From: Richard Levitte Date: Fri, 4 May 2018 12:44:19 +0000 (+0200) Subject: BIO_s_mem() write: Skip early when input length is zero X-Git-Tag: OpenSSL_1_0_2p~57 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8dd55d9ee107337460e6a35b4ece234b4475e12d;p=oweals%2Fopenssl.git BIO_s_mem() write: Skip early when input length is zero When the input length is zero, just return zero early. Otherwise, there's a small chance that memory allocation is engaged, fails and returns -1, which is a bit confusing when nothing should be written. Fixes #4782 #4827 Reviewed-by: Ben Kaduk (Merged from https://github.com/openssl/openssl/pull/6175) (cherry picked from commit 0d94212a046e87fafea6e83e8ea2b2a58db49979) --- diff --git a/crypto/bio/bss_mem.c b/crypto/bio/bss_mem.c index b0394a960d..6ccb8e2788 100644 --- a/crypto/bio/bss_mem.c +++ b/crypto/bio/bss_mem.c @@ -188,6 +188,8 @@ static int mem_write(BIO *b, const char *in, int inl) } BIO_clear_retry_flags(b); + if (inl == 0) + return 0; blen = bm->length; if (BUF_MEM_grow_clean(bm, blen + inl) != (blen + inl)) goto end;