From: Jo-Philipp Wich <jow@openwrt.org>
Date: Thu, 30 Jul 2009 11:06:12 +0000 (+0000)
Subject: libs/lmo: fix lmo_read32() (dereferencing type-punned pointer will break strict-alias... 
X-Git-Tag: 0.10.0~1280
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8c8ecd1fa90cc83ebe35cd2c1b46133c72a8b5f7;p=oweals%2Fluci.git

libs/lmo: fix lmo_read32() (dereferencing type-punned pointer will break strict-aliasing rules)
---

diff --git a/libs/lmo/src/lmo_core.c b/libs/lmo/src/lmo_core.c
index f9e533130..cd117bec8 100644
--- a/libs/lmo/src/lmo_core.c
+++ b/libs/lmo/src/lmo_core.c
@@ -22,13 +22,10 @@ extern char _lmo_error[1024];
 
 static int lmo_read32( int fd, uint32_t *val )
 {
-	uint8_t buffer[5];
-
-	if( read(fd, buffer, 4) < 4 )
+	if( read(fd, val, 4) < 4 )
 		return -1;
 
-	buffer[4] = 0;
-	*val = ntohl(*((uint32_t *) buffer));
+	*val = ntohl(*val);
 
 	return 4;
 }