From: Denis Vlasenko <vda.linux@googlemail.com>
Date: Tue, 31 Oct 2006 18:30:56 +0000 (-0000)
Subject: login: add big fat comment about SIGINT - prevent
X-Git-Tag: 1_4_0~431
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8c76487f06023f33ea0d92f686b29b958748d3f8;p=oweals%2Fbusybox.git

login: add big fat comment about SIGINT - prevent
adding/deleting that code again and again
---

diff --git a/loginutils/login.c b/loginutils/login.c
index 04283007b..2ad52c63e 100644
--- a/loginutils/login.c
+++ b/loginutils/login.c
@@ -386,7 +386,14 @@ auth_failed:
 	// /* TIOCSCTTY: steal tty from other process group */
 	// if (ioctl(0, TIOCSCTTY, 1)) error_msg...
 
-	signal(SIGALRM, SIG_DFL); /* set signals to defaults */
+	/* set signals to defaults */
+	signal(SIGALRM, SIG_DFL);
+	/* Is this correct? This way user can ctrl-c out of /etc/profile,
+	 * potentially creating security breach (tested with bash 3.0).
+	 * But without this, bash 3.0 will not enable ctrl-c either.
+	 * Maybe bash is buggy?
+	 * Need to find out what standards say about /bin/login -
+	 * should it leave SIGINT etc enabled or disabled? */
 	signal(SIGINT, SIG_DFL);
 
 	run_shell(tmp, 1, 0, 0);	/* exec the shell finally */