From: Bodo Möller <bodo@openssl.org>
Date: Mon, 9 Oct 2000 16:40:16 +0000 (+0000)
Subject: BIO_sock_init() returns 1 for success and -1 for failure, not 0;
X-Git-Tag: OpenSSL_0_9_6~1^2~1
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8c23788dd1f4e655d790f3e67a2e6f42feecb4cf;p=oweals%2Fopenssl.git

BIO_sock_init() returns 1 for success and -1 for failure, not 0;
thus the condition '!BIO_sock_init()' doesn't make sense.
---

diff --git a/crypto/bio/b_sock.c b/crypto/bio/b_sock.c
index 64310058b4..e971a07de0 100644
--- a/crypto/bio/b_sock.c
+++ b/crypto/bio/b_sock.c
@@ -113,8 +113,8 @@ int BIO_get_host_ip(const char *str, unsigned char *ip)
 
 	/* At this point, we have something that is most probably correct
 	   in some way, so let's init the socket. */
-	if (!BIO_sock_init())
-		return(0); /* don't generate another error code here */
+	if (BIO_sock_init() != 1)
+		return 0; /* don't generate another error code here */
 
 	/* If the string actually contained an IP address, we need not do
 	   anything more */
@@ -527,7 +527,7 @@ int BIO_get_accept_socket(char *host, int bind_mode)
 	unsigned long l;
 	int err_num;
 
-	if (!BIO_sock_init()) return(INVALID_SOCKET);
+	if (BIO_sock_init() != 1) return(INVALID_SOCKET);
 
 	if ((str=BUF_strdup(host)) == NULL) return(INVALID_SOCKET);