From: Dr. Stephen Henson <steve@openssl.org>
Date: Fri, 5 Aug 2016 13:33:03 +0000 (+0100)
Subject: Check for errors in a2d_ASN1_OBJECT()
X-Git-Tag: OpenSSL_1_1_0~187
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8b9afbc0fc7f8be0049d389d34d9416fa377e2aa;p=oweals%2Fopenssl.git

Check for errors in a2d_ASN1_OBJECT()

Check for error return in BN_div_word().

Reviewed-by: Tim Hudson <tjh@openssl.org>
---

diff --git a/crypto/asn1/a_object.c b/crypto/asn1/a_object.c
index 6fc7681c23..79f0ecd2a8 100644
--- a/crypto/asn1/a_object.c
+++ b/crypto/asn1/a_object.c
@@ -127,8 +127,12 @@ int a2d_ASN1_OBJECT(unsigned char *out, int olen, const char *buf, int num)
                 if (tmp == NULL)
                     goto err;
             }
-            while (blsize--)
-                tmp[i++] = (unsigned char)BN_div_word(bl, 0x80L);
+            while (blsize--) {
+                BN_ULONG t = BN_div_word(bl, 0x80L);
+                if (t == (BN_ULONG)-1)
+                    goto err;
+                tmp[i++] = (unsigned char)t;
+            }
         } else {
 
             for (;;) {