From: Kristian Amlie <kristian.amlie@northern.tech>
Date: Wed, 4 Apr 2018 08:09:57 +0000 (+0200)
Subject: fw_printenv: Fix crash due to incorrect size for malloc'ed string.
X-Git-Tag: v2018.05-rc2~30
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8a0b827b1a12cf3e224a4c083de7a1e448356a16;p=oweals%2Fu-boot.git

fw_printenv: Fix crash due to incorrect size for malloc'ed string.

Using sizeof gives the size of the pointer only, not the string. This
could easily lead to crashes when using -l argument.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
---

diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
index d93a915fd1..fb4afa5ee9 100644
--- a/tools/env/fw_env_main.c
+++ b/tools/env/fw_env_main.c
@@ -239,7 +239,7 @@ int main(int argc, char *argv[])
 	argv += optind;
 
 	if (env_opts.lockname) {
-		lockname = malloc(sizeof(env_opts.lockname) +
+		lockname = malloc(strlen(env_opts.lockname) +
 				sizeof(CMD_PRINTENV) + 10);
 		if (!lockname) {
 			fprintf(stderr, "Unable allocate memory");