From: Denis Vlasenko <vda.linux@googlemail.com>
Date: Tue, 10 Apr 2007 21:41:16 +0000 (-0000)
Subject: xargs: fix my brain fart (resulted in memory leak)
X-Git-Tag: 1_6_0~189
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=89054964443b5cb14cba673b86306f534810404a;p=oweals%2Fbusybox.git

xargs: fix my brain fart (resulted in memory leak)
---

diff --git a/findutils/xargs.c b/findutils/xargs.c
index 2b3a5081c..695091a04 100644
--- a/findutils/xargs.c
+++ b/findutils/xargs.c
@@ -113,10 +113,10 @@ static xlist_t *process_stdin(xlist_t *list_arg,
 	xlist_t *cur;
 	xlist_t *prev;
 
-	cur = list_arg;
+	prev = cur = list_arg;
 	while (1) {
-		prev = cur;
 		if (!cur) break;
+		prev = cur;
 		line_l += cur->length;
 		cur = cur->link;
 	}
@@ -142,7 +142,6 @@ static xlist_t *process_stdin(xlist_t *list_arg,
 				goto set;
 			}
 		} else { /* if(state == NORM) */
-
 			if (ISSPACE(c)) {
 				if (s) {
 unexpected_eof:
@@ -214,10 +213,10 @@ static xlist_t *process_stdin(xlist_t *list_arg,
 	xlist_t *cur;
 	xlist_t *prev;
 
-	cur = list_arg;
+	prev = cur = list_arg;
 	while (1) {
-		prev = cur;
 		if (!cur) break;
+		prev = cur;
 		line_l += cur->length;
 		cur = cur->link;
 	}
@@ -304,10 +303,10 @@ static xlist_t *process0_stdin(xlist_t *list_arg,
 	xlist_t *cur;
 	xlist_t *prev;
 
-	cur = list_arg;
+	prev = cur = list_arg;
 	while (1) {
-		prev = cur;
 		if (!cur) break;
+		prev = cur;
 		line_l += cur->length;
 		cur = cur->link;
 	}