From: Benjamin Kaduk <bkaduk@akamai.com>
Date: Thu, 7 Dec 2017 20:23:35 +0000 (-0600)
Subject: Fix coverity nit in handshake_helper.c
X-Git-Tag: OpenSSL_1_1_1-pre1~339
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=88e09fe79b909fbfe266e87a2731f96c197726fb;p=oweals%2Fopenssl.git

Fix coverity nit in handshake_helper.c

There's no reason to wrap this call in TEST_true() if we're not
checking the return value of TEST_true() -- all of the surrounding
similar calls do not have the macro wrapping them.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4873)
---

diff --git a/test/handshake_helper.c b/test/handshake_helper.c
index 78eaa012e2..0add973e50 100644
--- a/test/handshake_helper.c
+++ b/test/handshake_helper.c
@@ -497,8 +497,8 @@ static int configure_handshake_ctx(SSL_CTX *server_ctx, SSL_CTX *server2_ctx,
     case TLSEXT_max_fragment_length_2048:
     case TLSEXT_max_fragment_length_4096:
     case TLSEXT_max_fragment_length_DISABLED:
-        TEST_true(SSL_CTX_set_tlsext_max_fragment_length(
-                        client_ctx, extra->client.max_fragment_len_mode));
+        SSL_CTX_set_tlsext_max_fragment_length(
+              client_ctx, extra->client.max_fragment_len_mode);
         break;
     }