From: Paul Kocialkowski <contact@paulk.fr>
Date: Sat, 4 Apr 2015 13:12:28 +0000 (+0200)
Subject: usb: Check usb_new_device for failure
X-Git-Tag: v2015.07-rc1~424
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8879be88576024a48ae135ea0b3835727d8c9a3a;p=oweals%2Fu-boot.git

usb: Check usb_new_device for failure

This checks that a new USB device is correctly initialized and frees it if not.
In addition, this doesn't report that USB was started when no device was found.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---

diff --git a/common/usb.c b/common/usb.c
index 1288ca0592..6ed31240fe 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -95,18 +95,24 @@ int usb_init(void)
 		start_index = dev_index;
 		printf("scanning bus %d for devices... ", i);
 		dev = usb_alloc_new_device(ctrl);
+		if (!dev)
+			break;
+
 		/*
 		 * device 0 is always present
 		 * (root hub, so let it analyze)
 		 */
-		if (dev)
-			usb_new_device(dev);
+		ret = usb_new_device(dev);
+		if (ret)
+			usb_free_device();
 
-		if (start_index == dev_index)
+		if (start_index == dev_index) {
 			puts("No USB Device found\n");
-		else
+			continue;
+		} else {
 			printf("%d USB Device(s) found\n",
 				dev_index - start_index);
+		}
 
 		usb_started = 1;
 	}