From: Denis Vlasenko <vda.linux@googlemail.com>
Date: Mon, 21 May 2007 10:19:48 +0000 (-0000)
Subject: shells: update README and testsuite. environment memory leak
X-Git-Tag: 1_6_0~38
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8805eeb44a291b830e9eb1a430d112913ffa9a24;p=oweals%2Fbusybox.git

shells: update README and testsuite. environment memory leak
needs to be fixed - and documented!
---

diff --git a/shell/README b/shell/README
index d492671fb..919cb9fef 100644
--- a/shell/README
+++ b/shell/README
@@ -1,6 +1,20 @@
 Various bits of what is known about busybox shells, in no particular order.
 
-2006-05-06
+2007-05-21
+hush: environment cannot be handled by libc routines as they are leaky
+(by API design and thus unfixable): hush will leak memory in this script,
+bash does not:
+pid=$$
+while true; do
+    unset t;
+    t=111111111111111111111111111111111111111111111111111111111111111111111111
+    export t
+    ps -o vsz,pid,comm | grep " $pid "
+done
+The fix is to not use setenv/putenv/unsetenv but manipulate env ourself. TODO.
+hush: meanwhile, first three command subst bugs mentioned below are fixed. :)
+
+2007-05-06
 hush: more bugs spotted. Comparison with bash:
 bash-3.2# echo "TEST`date;echo;echo`BEST"
 TESTSun May  6 09:21:05 CEST 2007BEST         [we dont strip eols]
diff --git a/shell/hush_test/hush-parsing/process_subst.right b/shell/hush_test/hush-parsing/process_subst.right
index 8f9ab9d40..397bc8067 100644
--- a/shell/hush_test/hush-parsing/process_subst.right
+++ b/shell/hush_test/hush-parsing/process_subst.right
@@ -1,2 +1,3 @@
 TESTzzBEST
 TEST$(echo zz)BEST
+TEST'BEST
diff --git a/shell/hush_test/hush-parsing/process_subst.tests b/shell/hush_test/hush-parsing/process_subst.tests
index f8299a514..21996bc0e 100755
--- a/shell/hush_test/hush-parsing/process_subst.tests
+++ b/shell/hush_test/hush-parsing/process_subst.tests
@@ -1,2 +1,3 @@
 echo "TEST`echo zz;echo;echo`BEST"
 echo "TEST`echo '$(echo zz)'`BEST"
+echo "TEST`echo "'"`BEST"