From: Christian Grothoff <christian@grothoff.org>
Date: Sat, 14 Aug 2010 21:36:08 +0000 (+0000)
Subject: do not leak nullfd
X-Git-Tag: initial-import-from-subversion-38251~20703
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=874a73c6e814da43fdc895112a74b01c212e02f6;p=oweals%2Fgnunet.git

do not leak nullfd
---

diff --git a/src/util/service.c b/src/util/service.c
index 21841dd49..df5342c1d 100644
--- a/src/util/service.c
+++ b/src/util/service.c
@@ -1415,10 +1415,12 @@ detach_terminal (struct GNUNET_SERVICE_Context *sctx)
     return GNUNET_SYSERR;
   /* set stdin/stdout to /dev/null */
   if ((dup2 (nullfd, 0) < 0) || (dup2 (nullfd, 1) < 0))
-    {
+    {      
       GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "dup2");
+      (void) CLOSE (nullfd);
       return GNUNET_SYSERR;
     }
+  (void) CLOSE (nullfd);
   /* Detach from controlling terminal */
   pid = setsid ();
   if (pid == -1)