From: Simon Glass <sjg@chromium.org>
Date: Tue, 2 Oct 2018 03:12:42 +0000 (-0600)
Subject: binman: Separate out testSplBssPad()
X-Git-Tag: v2018.11-rc2~7^2~65
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=86af511d892df59f06bf49a71505a072ea2cd5f3;p=oweals%2Fu-boot.git

binman: Separate out testSplBssPad()

At present this test runs binman twice, which means that the temporary
files from the first run do not get cleaned up. Split this into two tests
to fix this problem.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
index 9ef259a699..ed78774560 100644
--- a/tools/binman/ftest.py
+++ b/tools/binman/ftest.py
@@ -1022,10 +1022,12 @@ class TestFunctional(unittest.TestCase):
         data = self._DoReadFile('47_spl_bss_pad.dts')
         self.assertEqual(U_BOOT_SPL_DATA + (chr(0) * 10) + U_BOOT_DATA, data)
 
+    def testSplBssPadMissing(self):
+        """Test that a missing symbol is detected"""
         with open(self.TestFile('u_boot_ucode_ptr')) as fd:
             TestFunctional._MakeInputFile('spl/u-boot-spl', fd.read())
         with self.assertRaises(ValueError) as e:
-            data = self._DoReadFile('47_spl_bss_pad.dts')
+            self._DoReadFile('47_spl_bss_pad.dts')
         self.assertIn('Expected __bss_size symbol in spl/u-boot-spl',
                       str(e.exception))