From: Paramat <paramat@users.noreply.github.com>
Date: Tue, 19 Jun 2018 21:09:42 +0000 (+0100)
Subject: Biome dust: Revert fix that added dust to mod structures (#7464)
X-Git-Tag: 5.0.0~351
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=86389329eba19231129ad14456aa3f689332fbb3;p=oweals%2Fminetest.git

Biome dust: Revert fix that added dust to mod structures (#7464)

Revert commit 99143f494711034068685b6ee845ce19fa09d7d9 and commit
f4ca830abe1aa22875c99b31bf2ee56e26f83f05.

These commits caused biome dust to be applied even when there was no core
mapgen terrain in a mapchunk column. So the dust, which overgenerates,
then appeared on structures added by mods in 'on_generated', such as
floatlands, asteroids or above-surface realms.
---

diff --git a/src/mapgen/mapgen.cpp b/src/mapgen/mapgen.cpp
index 360afd897..85aab363b 100644
--- a/src/mapgen/mapgen.cpp
+++ b/src/mapgen/mapgen.cpp
@@ -763,16 +763,6 @@ void MapgenBasic::generateBiomes()
 
 			VoxelArea::add_y(em, vi, -1);
 		}
-		// If no stone surface was detected in this mapchunk column the biomemap
-		// will be empty for this (x, z) position. Add the currently active
-		// biome to the biomemap, or if biome is NULL calculate it for this
-		// position and add it.
-		if (biomemap[index] == BIOME_NONE) {
-			if (!biome)
-				biome = biomegen->getBiomeAtIndex(
-					index, v3s16(x, node_min.Y, z));
-			biomemap[index] = biome->index;
-		}
 	}
 }