From: Rich Felker Date: Tue, 7 Jan 2014 03:03:38 +0000 (-0500) Subject: const-qualify the address argument to dladdr X-Git-Tag: v1.0.0~107 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=839cc4e6da609a0b24f6cc32b0b11558fd77dd83;p=oweals%2Fmusl.git const-qualify the address argument to dladdr this agrees with implementation practice on glibc and BSD systems, and is the const-correct way to do things; it eliminates warnings from passing pointers to const. the prototype without const came from seemingly erroneous man pages. --- diff --git a/include/dlfcn.h b/include/dlfcn.h index db26194b..78fb0733 100644 --- a/include/dlfcn.h +++ b/include/dlfcn.h @@ -31,7 +31,7 @@ typedef struct { const char *dli_sname; void *dli_saddr; } Dl_info; -int dladdr(void *, Dl_info *); +int dladdr(const void *, Dl_info *); int dlinfo(void *, int, void *); #endif diff --git a/src/ldso/dladdr.c b/src/ldso/dladdr.c index 265bb681..7ca718f4 100644 --- a/src/ldso/dladdr.c +++ b/src/ldso/dladdr.c @@ -1,9 +1,9 @@ #define _GNU_SOURCE #include -int __dladdr(void *, Dl_info *); +int __dladdr(const void *, Dl_info *); -int dladdr(void *addr, Dl_info *info) +int dladdr(const void *addr, Dl_info *info) { return __dladdr(addr, info); } diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c index 27d92f2b..89e1260b 100644 --- a/src/ldso/dynlink.c +++ b/src/ldso/dynlink.c @@ -1331,7 +1331,7 @@ failed: return 0; } -int __dladdr(void *addr, Dl_info *info) +int __dladdr(const void *addr, Dl_info *info) { struct dso *p; Sym *sym; @@ -1441,7 +1441,7 @@ void *__dlsym(void *restrict p, const char *restrict s, void *restrict ra) { return 0; } -int __dladdr (void *addr, Dl_info *info) +int __dladdr (const void *addr, Dl_info *info) { return 0; }