From: Charles de Lacombe <ealhad@mail.com>
Date: Wed, 28 Mar 2018 09:43:09 +0000 (+0200)
Subject: Add a hover effect on left menu links (#418) (#425)
X-Git-Tag: v1.0.0-beta.3~11
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=829be6e8b7e9a09f118577745906c19926c20416;p=oweals%2Fpeertube.git

Add a hover effect on left menu links (#418) (#425)

I:
- removed the `margin-left` on the `.panel-block` to put it on the children
instead
- squashed the `margin-bottom` of the links into their `height` (and rounded it
to 40px, feel free to correct me)
- centered vertically the content of the links
- added the `background-color` change on hover for the links

I put the same color as the `.logged-in-block`. Maybe it should be externalized
as a SCSS variable?

I also added a CSS transition. Is it alright?
---

diff --git a/client/src/app/menu/menu.component.scss b/client/src/app/menu/menu.component.scss
index da5a581a1..c36a7aa36 100644
--- a/client/src/app/menu/menu.component.scss
+++ b/client/src/app/menu/menu.component.scss
@@ -91,22 +91,27 @@ menu {
     font-weight: $font-bold; // Bold
     font-size: 13px;
     margin-bottom: 25px;
+    margin-left: 26px;
   }
 
   .panel-block {
     margin-bottom: 45px;
-    margin-left: 26px;
 
     a {
       display: flex;
+      align-items: center;
+      padding-left: 26px;
       color: $menu-color;
       cursor: pointer;
-      height: 22px;
-      line-height: 22px;
+      height: 40px;
       font-size: 16px;
-      margin-bottom: 15px;
+      transition: background-color .1s ease-in-out;
       @include disable-default-a-behaviour;
 
+      &:hover {
+        background-color: rgba(255, 255, 255, 0.15);
+      }
+
       .icon {
         @include icon(22px);