From: Gaƫtan Rizio Date: Sun, 8 Jul 2018 11:08:35 +0000 (+0200) Subject: [#766] Fix the change of speed when quality changes X-Git-Tag: v1.0.0-beta.10.pre.1~94 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=8244e18719e10ab1a376506ee30f941e5725e8ed;p=oweals%2Fpeertube.git [#766] Fix the change of speed when quality changes When changing the `playbackRate` of the video then changing the quality, the `playbackRate` returned to its initial value (1). The reason behind it is that the callback was not called when change of the quality was done if there was no error. This commit does the following: * Ensure the callback (`done`) is called after changing the quality --- diff --git a/client/src/assets/player/peertube-videojs-plugin.ts b/client/src/assets/player/peertube-videojs-plugin.ts index 32cc4cd8f..936fb2577 100644 --- a/client/src/assets/player/peertube-videojs-plugin.ts +++ b/client/src/assets/player/peertube-videojs-plugin.ts @@ -240,6 +240,8 @@ class PeerTubePlugin extends Plugin { if (options.seek) this.seek(options.seek) if (options.forcePlay === false && paused === true) this.player.pause() + + return done(err) }) }) }, options.delay || 0)