From: Robert Griebl <griebl@gmx.de>
Date: Tue, 20 Jul 2004 15:43:57 +0000 (-0000)
Subject: new_process_module_arguments returns 0 on error and 1 if everything went ok
X-Git-Tag: 1_00_rc2~36
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=809387fe9e47d5b3a62764ffdd0278194361ca7f;p=oweals%2Fbusybox.git

new_process_module_arguments returns 0 on error and 1 if everything went ok
somehow the ! got lost..
symptoms: modules could only be loaded _without_ parameters
---

diff --git a/modutils/insmod.c b/modutils/insmod.c
index 50cf007f0..d1aa24f14 100644
--- a/modutils/insmod.c
+++ b/modutils/insmod.c
@@ -290,7 +290,7 @@ extern int insmod_ng_main( int argc, char **argv);
 #ifndef MODUTILS_MODULE_H
 static const int MODUTILS_MODULE_H = 1;
 
-#ident "$Id: insmod.c,v 1.121 2004/06/22 20:10:53 andersen Exp $"
+#ident "$Id: insmod.c,v 1.122 2004/07/20 15:43:57 sandman Exp $"
 
 /*======================================================================*/
 /* For sizeof() which are related to the module platform and not to the
@@ -448,7 +448,7 @@ int delete_module(const char *);
 #ifndef MODUTILS_OBJ_H
 static const int MODUTILS_OBJ_H = 1;
 
-#ident "$Id: insmod.c,v 1.121 2004/06/22 20:10:53 andersen Exp $"
+#ident "$Id: insmod.c,v 1.122 2004/07/20 15:43:57 sandman Exp $"
 
 /* The relocatable object is manipulated using elfin types.  */
 
@@ -3865,7 +3865,7 @@ extern int insmod_main( int argc, char **argv)
 	++optind;
 
 	if (optind < argc) {
-		if (new_process_module_arguments(f, argc - optind, argv + optind))
+		if (!new_process_module_arguments(f, argc - optind, argv + optind))
 		{
 			goto out;
 		}