From: Peter Howkins <flibble@users.sf.net>
Date: Fri, 13 Jul 2018 17:06:36 +0000 (+0100)
Subject: dtcm: Coverity 89081
X-Git-Tag: 2.3.0a~104
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=803d0f94e52ee728dc1d6bfa3b273baa0699e732;p=oweals%2Fcde.git

dtcm: Coverity 89081
---

diff --git a/cde/programs/dtcm/server/rtable2.c b/cde/programs/dtcm/server/rtable2.c
index 3969ca71..e8b92f39 100644
--- a/cde/programs/dtcm/server/rtable2.c
+++ b/cde/programs/dtcm/server/rtable2.c
@@ -347,13 +347,14 @@ _DtCm_register_callback_2_svc(Registration_2 *r, struct svc_req *svcrq)
         static Registration_Status_2 stat;    
         Registration_4 *newreg;       
 	Registration_Status_4 *newstat;
-          
-        newreg = _DtCm_reg2_to_reg4(r);      
-        newstat = _DtCm_register_callback_4_svc(newreg, svcrq);      
-                 
-        stat = _DtCm_regstat4_to_regstat2(*newstat);      
-      
-        if (newreg!=NULL) xdr_free((xdrproc_t)_DtCm_xdr_Registration_4, (char*)newreg);        
+
+        newreg = _DtCm_reg2_to_reg4(r);
+        if(newreg) {
+                newstat = _DtCm_register_callback_4_svc(newreg, svcrq);
+                stat = _DtCm_regstat4_to_regstat2(*newstat);
+
+                xdr_free((xdrproc_t)_DtCm_xdr_Registration_4, (char*)newreg);
+        }
 	return(&stat);
 }